feat!(Contracts): assert success if Execute.success_required#30
Merged
feat!(Contracts): assert success if Execute.success_required#30
Execute.success_required#30Conversation
fubuloubu
force-pushed
the
fix/contracts/assert-success
branch
from
c7fe4d9 to
8c972ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Noticed that calls could silently fail because we never handle success, so added additional field
.success_requiredtoExecutemessage to ensure that it doesAlso makes a change to incorporate the deterministic deployment addresses directly into the SDK since they do not exist otherwise
How I did it
How to verify it
Checklist