Bugfix/1827 invalid cross device link#1829
Bugfix/1827 invalid cross device link#1829martindurant merged 10 commits intofsspec:masterfrom siemdejong:bugfix/1827_invalid-cross-device-link
Conversation
|
Creating the temporary file next to the target path (making sure it's on the same device) solves this issue. Took inspiration from filesystem_spec/fsspec/utils.py Lines 616 to 618 in 6cc68c7 This seems to work as expected with shutil.move.
Then It is difficult to mock the cross-device issue as it requires a temporary file on another device than the target device, so I mock this as an EXDEV at |
|
Why do the tests fail? These tests sporadically fail locally, but not always. And I get these errors also sporadically on master. |
|
I'm not sure if this is the cleanest way to do it. I'm also not sure if |
Fixes #1827