Fix some block comments in Rational #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parens and the div operator as real children of the RationalNode. Fixes fsprojects#2930, fsprojects#2932, fsprojects#2933
dawedawe
force-pushed
the
fix_2930_2932_2933
branch
from
b6df903 to
6a544e6
Compare
…4b54707e3e8541fe758e1aa22132a8fe
nojaf
reviewed
Aug 29, 2023
Contributor
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Looks good, one open question left.
Member
Author
Thanks, especially for the help and discussion regarding the AST change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2930
Fixes #2932
Fixes #2933