Adjust to optional lhs of SynMeasure.Divide #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjust to optional lhs of Measure.Divide
nojaf
reviewed
Jul 20, 2023
Contributor
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
So far so good.
I think you can add some more tests where we now deal with trivia better.
src/Fantomas.Core/ASTTransformer.fs
Outdated
| | SynRationalConst.Integer i -> string i | ||
| | SynRationalConst.Rational(numerator, denominator, _) -> $"(%i{numerator}/%i{denominator})" | ||
| | SynRationalConst.Negate innerRc -> $"-{visit innerRc}" | ||
| | SynRationalConst.Integer(value = i) -> string i |
Contributor
There was a problem hiding this comment.
If you have the ranges you want to use creationAide.TextFromSource where possible.
src/Fantomas.Core/CodePrinter.fs
Outdated
| | Measure.Divide n -> | ||
| let lhs = n.LeftHandSide |> Option.map genMeasure |> Option.defaultValue id | ||
|
|
||
| lhs |
Contributor
There was a problem hiding this comment.
Use optSingle genMeasure n.LeftHandSide
…7b5e12842d673b7daa467e0091378bf4acc95e4f - add test - add CHANGELOG entry
Member
Author
|
Hey @josh-degraw , |
josh-degraw
approved these changes
Jul 23, 2023
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the new modeling of
SynMeasure.Divide.Now that the
measure1is optional, we have a chance to see, if the original code had it or not.fixes #2926 and #2927