Backticks in optional parameter gets removed

[jindraivanek]

Issue created from fantomas-online

Code

type C() =
    static member foo(?``type``) = ``type``
        

Result

type C() =
    static member foo(?type) = ``type``

Problem description

Backticks removed in ?type - incorrect code.

Probably related to #2731.

Extra information

• The formatted result breaks my code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.
• I would like a release if this problem is solved.

Options

Fantomas main branch at 2023-08-31T06:37:49Z - 369faf8

Default Fantomas configuration

[nojaf]

Hi there,

We don't process SynPat.OptionalVal correctly in

fantomas/src/Fantomas.Core/ASTTransformer.fs

Line 1633 in bbecd22

| SynPat.OptionalVal(ident, _) -> stn $"?{ident.idText}" patternRange |> Pattern.OptionalVal

It should be more something like:

let identNode = mkIdent ident
SingleTextNode($"?{identNode.Text}", patternRange) |> Pattern.OptionalVal

Are you interested in submitting a PR?

[jindraivanek]

Are you interested in submitting a PR?

Yes, it looks simple enough :)