Fantomas5

[sergey-tihon]

This draft is here to check with maintainers and core contributors Fantomas 5 formatting and decide merge or don't

Detected issues:

• Stroustrup record type definition with access modifiers and members lead to invalid F# code fantomas#2511
• Sharpx.Collections/SkewBinomialHeapTest.fs lead to invalid F# code fantomas#2512
• Conditional directives before expression leads to invalid code with Stroustrup fantomas#2517
• Indexed property setter fantomas#2518

Would love to hear opinions/reactions from @forki @jackfoxy @pblasucci @eacasanovaspedre @gdziadkiewicz @sideeffffect @gsvgit

[pblasucci]

My mother always told me, "if you don't have anything nice to say, don't say anything at all."
😉

So I'll abstain, and leave the decisions to folks who have more skin in the game. 👍

[sideeffffect]

I've always liked automated formatting. But it's been such a long time since I've contributed to this repository that I don't feel my voice has much value 😉

[gdziadkiewicz]

I love the idea! Can we somehow help with the initiative?

[sergey-tihon]

I love the idea! Can we somehow help with the initiative?

I think that I do not need technical help, PR is already green. I'll wait for the next patch release for Fantomas to update it and format ignored files.

But I need help with the review of the change. Currently, I used my .editorconfig with some personal preferences for F# code formation. We need to check if it works for all contributors and maybe change something if it does not fil this project.

[gdziadkiewicz]

@sergey-tihon is this ready for review?

[sergey-tihon]

@gdziadkiewicz yes, but after merging this we break all other PRs

[dsyme]

@sergey-tihon @gdziadkiewicz You should proceed with this - other PRs can be fixed up by

1. merging up to just before this PR
2. formatting the PR according the the rules in this repo
3. merging this PR and then merging main

[dsyme]

BTW looking through the code in this repo reminds me what an excellent set of F# samples it is

[gdziadkiewicz]

@sergey-tihon could you refresh this branch with master and resolve those two small conflicts?

[sergey-tihon]

@gdziadkiewicz done