Adds PersistentVector.mapi#186
Conversation
| for i in 1..300 do i * 2 |> Expect.equal "map" a.[i-1] } | ||
|
|
||
| test "vector should allow mapi" { | ||
| let vector = ref PersistentVector.empty |
There was a problem hiding this comment.
Why is ref cell needed? Can't we handle it using mutable?
There was a problem hiding this comment.
Copied from the test above "vector with 300 elements should allow pop"
There was a problem hiding this comment.
Happy to change it to mutable (I prefer that too) but was trying to follow style of existing code.
There was a problem hiding this comment.
I missed that the rest of the file approaches it like that. I would leave it as it is and potentially tackle all of the ref cells in tests in separate PR. @jackfoxy what's your opinion on that?
|
Sorry to bump @gdziadkiewicz |
|
Feel free to bump me as much as necessary. The problem is that I don't have merge rights for this repo. @forki @mausch @jackfoxy @fsprojectsgit are you able to help with reviewing and merging this PR? |
|
Sorry to bump! |
|
@dsyme please remove me from this and any other FsProjects repos I may be as a maintainer. |
|
I'm willing to contribute as an maintainer if an maintainer is needed. |
|
@gdziadkiewicz Lovely, I'll add you as maintainer in this one @jackfoxy I'll remove you - many thanks for everything you've contributed to this and the other projects over time!! |
|
Released in 3.1.0 https://www.nuget.org/packages/FSharpx.Collections/3.1.0 |
4 participants
This mirrors
List.mapiandSeq.mapiin the core library.