Support all ImmutableArray functions as in Array module#18
Open
xperiandri wants to merge 5 commits intomainfrom
Open
Support all ImmutableArray functions as in Array module#18xperiandri wants to merge 5 commits intomainfrom
ImmutableArray functions as in Array module#18xperiandri wants to merge 5 commits intomainfrom
Conversation
ImmutableArray functions as in Array module
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive support for ImmutableArray functions modeled after the Array module, including a large suite of new tests and internal helper updates. Key changes include:
- New test files covering nearly every aspect of FlatList operations (creation, manipulation, iteration, folding, etc.) and additional builder functionality.
- Removal of the old ImmutableCollectionUtil.fs file with its functionality migrated into Helper.fs.
- Update of the test project file to target .NET 9.0.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.Collections.Immutable.Tests/Helpers.fs | Introduces helper functions (fstv, sndv) for testing. |
| tests/FSharp.Collections.Immutable.Tests/FlatList/UtilityTests.fs | Adds tests for FlatList functions; note a typo in a test name. |
| tests/FSharp.Collections.Immutable.Tests/FlatList/*.fs | New tests covering flat list creation, manipulation, sorting, etc. |
| tests/FSharp.Collections.Immutable.Tests/FSharp.Collections.Immutable.Tests.fsproj | Changes target framework from net8.0 to net9.0. |
| src/FSharp.Collections.Immutable/ImmutableCollectionUtil.fs | Removed internal file, functionality merged into Helper.fs. |
| src/FSharp.Collections.Immutable/Helper.fs | Now contains internal helper modules and utility functions. |
tests/FSharp.Collections.Immutable.Tests/FlatList/UtilityTests.fs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for all the functions as in similar FSharp.Core modules
Types of changes
Checklist