Skip to content

Conversation

@carmenbianca
Copy link
Member

Fixes #186

@carmenbianca carmenbianca added this to the v1.1.0 milestone Oct 12, 2022
@carmenbianca carmenbianca force-pushed the deprecated-download branch 2 times, most recently from f17426a to 2ed3b46 Compare October 12, 2022 18:17
Copy link
Member

@nicorikken nicorikken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@carmenbianca
Copy link
Member Author

Can't be merged; needs to use urllib instead of requests.

@carmenbianca carmenbianca marked this pull request as draft January 11, 2023 09:24
@floriansnow
Copy link
Contributor

Can't be merged; needs to use urllib instead of requests.

Would you please elaborate a bit about that problem? The code looks good to me.

Also, in order to fix #186 completely, should we perhaps only issue the message about a broken connection in case we can't download any licenses? We could even try to access a known-good license as a check.

@carmenbianca
Copy link
Member Author

Would you please elaborate a bit about that problem? The code looks good to me.

After this PR was created, we merged a PR that removed the (direct) dependency on requests. The test code currently mocks/monkeypatches the requests library. We'll have to rewrite that line of code to use urllib instead.

Also, in order to fix #186 completely, should we perhaps only issue the message about a broken connection in case we can't download any licenses? We could even try to access a known-good license as a check.

I don't know. It would be nice to improve the error handling and/or error message here, but I'm more inclined to do that as a separate issue/PR.

@floriansnow
Copy link
Contributor

Is there still interest in these changes?

Signed-off-by: Carmen Bianca Bakker <[email protected]>
@carmenbianca carmenbianca marked this pull request as ready for review October 27, 2025 10:54
@carmenbianca carmenbianca merged commit a2dbe72 into fsfe:main Oct 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reuse download $DEPRECATED gives unexpected result

4 participants