Skip to content

Conversation

@DataTriny
Copy link
Contributor

Sorry for the trouble, I am a noobie with git!

Here is a new PR containing only my changes, with proper code formatting.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 706

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.071%

Totals Coverage Status
Change from base Build 703: 0.0%
Covered Lines: 1
Relevant Lines: 1406

💛 - Coveralls

@fschutt
Copy link
Owner

fschutt commented Jan 2, 2019

Yeah, I think it's okay. A few linebreaks too many, but those are small style issues that I can fix in post. I currently can't build this repository (still working on fixing dependency issues in #80 so that I can build this repo again), but it's just an example, so it's not a big deal and if yatekii says it works then I trust him.

@fschutt fschutt merged commit 864de10 into fschutt:master Jan 2, 2019
fschutt added a commit that referenced this pull request May 13, 2019
Fixed calculator example, implemented proper business logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants