Merged
Conversation
enddynayn
changed the title
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
2 times, most recently
from
d0479f9 to
3bbe0b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
3bbe0b8 to
b023185
Compare
github-actions
bot
removed
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
b023185 to
e03bfb2
Compare
enddynayn
changed the title
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
0862140 to
ca0ed47
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
3 times, most recently
from
6bbac99 to
1fee438
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
0bc1c30 to
9cfffa4
Compare
github-actions
bot
removed
the
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
2 times, most recently
from
eb27333 to
d624673
Compare
github-actions
bot
added
the
metadata-changed
JoeCap08055
approved these changes
Aug 29, 2024
Collaborator
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
- Pulled branch
- Built/ran unit tests
- Ran e2e tests
- Looks good!
aramikm
reviewed
Aug 29, 2024
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Great effort!. Added some comments and suggestions.
github-actions
bot
added
metadata-changed
shannonwells
approved these changes
Aug 30, 2024
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
Assuming all the CI checks out... nice work, that was a long row to hoe. My comments are just questions to make sure I understand - it looks like this upgrade allows async backing but we're not turning it on fully for mainnet, is that right?
mattheworris
approved these changes
Aug 30, 2024
Collaborator
mattheworris
left a comment
mattheworris
left a comment
There was a problem hiding this comment.
- Read through changes.
Nice work!
🚢 it!
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
a054892 to
07c292e
Compare
github-actions
bot
removed
the
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
2 times, most recently
from
b0c8218 to
03c4ade
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
03c4ade to
f475528
Compare
github-actions
bot
added
metadata-changed
aramikm
reviewed
Sep 4, 2024
github-actions
bot
added
the
metadata-changed
- Upgrade Polkadot-sdk 1.10.0 to 1.13.0 - Update weights to reflect the new version.1.13.0 Notable Changes: Polkadot-sdk 1.12.0 - [Improve MockValidationDataInherentDataProvider to support async backing](paritytech/polkadot-sdk#4442) - [Balances-Pallet add burn_allow_death extrinsic](paritytech/polkadot-sdk#3964) - [Add Async Backing to Parachain Template](paritytech/polkadot-sdk#4295) Polkadot-sdk 1.13.0 - [DeprecatedRuntimeGenesisConfig generic type parameter in GenericChainSpec struct](paritytech/polkadot-sdk#4410) - [Move the `para_id` from `MockXcmConfig` to `MockValidationDataInherentDataProvider` to make it more prominent](paritytech/polkadot-sdk#4555) - [Remove parameterized-consensus-hook feature](paritytech/polkadot-sdk#4380) For more details, please refer to: - [Polkadot-sdk release 1.12.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.12.0) - [Polkadot-sdk release 1.13.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.13.0) - [Async Backing](https://wiki.polkadot.network/docs/maintain-guides-async-backing) issue-2025 issue-1983
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
from
60c4714 to
e1534cf
Compare
github-actions
bot
added
metadata-changed
enddynayn
deleted the
chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes:
Polkadot-sdk 1.12.0
Polkadot-sdk 1.13.0
para_idfromMockXcmConfigtoMockValidationDataInherentDataProviderto make it more prominentFor more details, please refer to:
#2025
#1983