Merged
Conversation
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
4 times, most recently
from
474c0f9 to
9b6fa5c
Compare
enddynayn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
from
2a7dccd to
0e84494
Compare
github-actions
bot
removed
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
from
0e84494 to
f95ebf1
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
3 times, most recently
from
80a8804 to
672b981
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
8 times, most recently
from
dbceeab to
e19190b
Compare
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0 - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macro](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) - [Refactor Unified Host Functions](paritytech/polkadot-sdk#3854) - [StorageWeightReclaim SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
from
21a1260 to
06462ac
Compare
enddynayn
requested review from
JoeCap08055,
aramikm,
claireclark1 and
saraswatpuneet
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
saraswatpuneet
approved these changes
Aug 1, 2024
Collaborator
saraswatpuneet
left a comment
saraswatpuneet
left a comment
There was a problem hiding this comment.
Did not notice any major changes aside from big refactor which look 👍🏽
github-actions
bot
removed
the
metadata-changed
aramikm
approved these changes
Aug 1, 2024
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Read the code and looked good. There are some questions about weight changes. In general they are decreased but they are increased for base block and base extrinsic.
| // Minimum execution time: 39_381_000 picoseconds. | ||
| Weight::from_parts(40_678_000, 6249) | ||
| // Minimum execution time: 35_236_000 picoseconds. | ||
| Weight::from_parts(36_395_000, 6249) |
Collaborator
There was a problem hiding this comment.
nit: Do we know why this is reduced?
| /// 75th: 356_675 | ||
| pub const BlockExecutionWeight: Weight = | ||
| Weight::from_parts(WEIGHT_REF_TIME_PER_NANOS.saturating_mul(245_079), 0); | ||
| Weight::from_parts(WEIGHT_REF_TIME_PER_NANOS.saturating_mul(355_340), 0); |
Collaborator
There was a problem hiding this comment.
nit: I wonder why is this increased 100k
Collaborator
Author
There was a problem hiding this comment.
Good question. We added a new Signed Extension.
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
from
62b42de to
3aa9a19
Compare
github-actions
bot
added
the
metadata-changed
claireclark1
approved these changes
Aug 1, 2024
Collaborator
claireclark1
left a comment
claireclark1
left a comment
There was a problem hiding this comment.
Not really any logic changes or anything. As long as it works, LGTM!
enddynayn
deleted the
chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes:
For more details, please refer to:
Release Notes
#1928