Merged
Conversation
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870
branch
2 times, most recently
from
fda9318 to
a7b2675
Compare
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870
branch
from
a7b2675 to
bfc6f8c
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870
branch
2 times, most recently
from
711e0cc to
d4e48b2
Compare
enddynayn
commented
Jul 11, 2024
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870
branch
from
d4e48b2 to
fe32d17
Compare
enddynayn
requested review from
JoeCap08055,
aramikm,
claireclark1,
mattheworris,
saraswatpuneet and
shannonwells
Codecov ReportAttention: Patch coverage is
|
github-actions
bot
added
the
metadata-changed
- Upgrade Polkadot-sdk to v.1.7.0. - Update weights to reflect the new version. Notable Changes: - [Allow custom error types in Jsonrpsee](paritytech/polkadot-sdk#1313) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.7.0) issue-1870
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870
branch
from
70bd40c to
c6702ac
Compare
github-actions
bot
added
metadata-changed
| @@ -1,19 +1,19 @@ | |||
| use core::result::Result as CoreResult; | |||
| use jsonrpsee::{ | |||
| core::{Error as RpcError, RpcResult}, | |||
claireclark1
approved these changes
Jul 11, 2024
Collaborator
claireclark1
left a comment
claireclark1
left a comment
There was a problem hiding this comment.
Happy to approve, but I don't feel like I'm qualified enough to understand the purpose of a lot of these changes, specifically in reference to the parts value changes.
Lots of good type changes.
aramikm
approved these changes
Jul 12, 2024
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Looks great!
I think there might be some questions about how this back-pressure implementation which supports 65 messages per connection by default might have some effects on our apps subscribing to the chain.
shannonwells
approved these changes
Jul 12, 2024
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
Looks good to go.
I reviewed the code, I analyzed the weights changes (w/ chatgpt), I reviewed the linked polkadot-sdk PRs.
saraswatpuneet
approved these changes
Jul 12, 2024
Collaborator
saraswatpuneet
left a comment
saraswatpuneet
left a comment
There was a problem hiding this comment.
Read through code and comments
Great job 👏🏽
Collaborator
Author
Thanks! Thats a good point. Ill create an issue so that we can properly configure backpressure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes:
For more details, please refer to:
Release Notes
#1870