Skip to content

Polkadot v0.9.39 upgrade#1581

Merged
mattheworris merged 9 commits intomainfrom
polkadot-0939-upgrade
Jun 6, 2023
Merged

Polkadot v0.9.39 upgrade#1581
mattheworris merged 9 commits intomainfrom
polkadot-0939-upgrade

Conversation

@mattheworris
Copy link
Copy Markdown
Collaborator

@mattheworris mattheworris commented Jun 5, 2023 •
edited
Loading

Goal

The goal of this PR is upgrade Polkadot to v0.9.39

See:
https://github.com/paritytech/polkadot/releases/tag/v0.9.39
https://github.com/paritytech/polkadot/releases/tag/v0.9.39-1
https://github.com/paritytech/polkadot/releases/tag/v0.9.39-rc6

Closes #1208

Discussion

Checklist

  • Chain spec updated
  • Tests
    • make ci-local: all tests passing
  • Weights updated
  • Extrinsics Added to Pallet Democracy
    • set_external_metadata
    • clear_external_metadata
    • set_proposal_metadata
    • clear_proposal_metadata
    • set_referendum_metadata
    • clear_referendum_metadata

@mattheworris mattheworris force-pushed the polkadot-0939-upgrade branch from f56c3d9 to 2916f7a Compare June 5, 2023 23:05
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 5, 2023

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #1581 (2f8ea3c) into main (24a5588) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   73.55%   73.59%   +0.04%     
==========================================
  Files          51       51              
  Lines        4912     4912              
==========================================
+ Hits         3613     3615       +2     
+ Misses       1299     1297       -2
Impacted Files Coverage Δ
pallets/handles/src/rpc/src/lib.rs 87.80% <100.00%> (ø)
pallets/messages/src/rpc/src/lib.rs 96.00% <100.00%> (ø)
pallets/msa/src/rpc/src/lib.rs 90.90% <100.00%> (ø)
pallets/schemas/src/rpc/src/lib.rs 90.32% <100.00%> (ø)
pallets/stateful-storage/src/rpc/src/lib.rs 84.21% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 6, 2023
@mattheworris mattheworris marked this pull request as ready for review June 6, 2023 00:03
@mattheworris mattheworris requested a review from wilwade as a code owner June 6, 2023 00:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2023

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 060f33f.

@mattheworris mattheworris requested a review from a team June 6, 2023 00:04
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 6, 2023
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 6, 2023
@mattheworris mattheworris self-assigned this Jun 6, 2023
wilwade
wilwade requested changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I want to make sure about before merging, but otherwise it is good!

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 6, 2023
enddynayn
enddynayn approved these changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Nice!

enddynayn
enddynayn approved these changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Nice!

wilwade
wilwade approved these changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

  • Checked export-metadata
  • Checked make start
  • checked mainnet start syncing

@mattheworris mattheworris merged commit cf786d9 into main Jun 6, 2023
@mattheworris mattheworris deleted the polkadot-0939-upgrade branch June 6, 2023 19:07
mattheworris pushed a commit that referenced this pull request Jun 6, 2023
@do-not-reply @mattheworris
Update weights for PR #1581
a13fc61
mattheworris pushed a commit that referenced this pull request Jun 8, 2023
@do-not-reply
Update weights for PR #1581
c73e8c8
mattheworris pushed a commit that referenced this pull request Jun 14, 2023
@do-not-reply @mattheworris
Update weights for PR #1581
e6ca0c6
@demisx demisx added the change/major Major Changes in this PR label Jun 16, 2023
shannonwells pushed a commit that referenced this pull request Apr 16, 2024
@mattheworris @do-not-reply @shannonwells
Polkadot v0.9.39 upgrade (#1581)
0e89745 
# Goal
The goal of this PR is upgrade Polkadot to v0.9.39

See: 
https://github.com/paritytech/polkadot/releases/tag/v0.9.39
https://github.com/paritytech/polkadot/releases/tag/v0.9.39-1
https://github.com/paritytech/polkadot/releases/tag/v0.9.39-rc6

Closes #1208 

# Discussion
<!-- List discussion items -->

# Checklist
- [x] Chain spec updated
- [x] Tests
  - [x] make ci-local: all tests passing
- [x] Weights updated
- [x] Extrinsics Added to Pallet Democracy
  - `set_external_metadata`
  - `clear_external_metadata`
  -  `set_proposal_metadata`
  -  `clear_proposal_metadata`
  -  `set_referendum_metadata`
  -  `clear_referendum_metadata`

---------

Co-authored-by: Frequency CI [bot] <do-not-reply@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aramikm aramikm aramikm left review comments

@wilwade wilwade wilwade approved these changes

@enddynayn enddynayn enddynayn approved these changes

+2 more reviewers

@rlaferla rlaferla rlaferla left review comments

@johnmela johnmela johnmela approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattheworris mattheworris

Labels

change/major Major Changes in this PR metadata-changed Metadata has changed since the latest full release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Polkadot Release v0.9.39-1

8 participants

@mattheworris @rlaferla @wilwade @enddynayn @johnmela @aramikm @demisx @do-not-reply