Hotfix: Apply pallet treasury migration#905
Merged
asiniscalchi merged 8 commits intorelease/v0.24from Dec 11, 2024
Merged
Conversation
luispdm
approved these changes
Dec 10, 2024
asiniscalchi
approved these changes
Dec 11, 2024
asiniscalchi
added a commit
that referenced
this pull request
Dec 12, 2024
* using public node (#904) * Add pallet treasury with its migration and test * Update golden * Solve clippy issues * fmt * Change hardcoded weight * fmt --------- Co-authored-by: Alessandro Siniscalchi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deleted some dispatchables in pallet treasury. Those changes were applied in LAOS Sigma 2400, leading to the UI in issue shown in the picture, originated cause there was a pending treasury proposal when the runtime was updated, and Polkadot JS tries to call one of those dispatchables ;(
This migration solves the problem, but it's not applied in polkadot-sdk versions prior stable2412. As we cannot update to that version yet, to solve the issue in Sigma we temporarily fork pallet treasury (as it is in polkadot-sdk stable2407, out of some changes needed to pass our clippy CI) in LAOS and apply the dedicated migration to our runtime as a hotfix.