Closed
Conversation
ghost
commented
Feb 26, 2024
| /// Just the `Currency::Balance` type; we have this item to allow us to | ||
| /// constrain it to `From<u64>`. | ||
| /// Note: Definition taken from pallet_gilt | ||
| type CurrencyBalance: sp_runtime::traits::AtLeast32BitUnsigned |
Author
There was a problem hiding this comment.
all of these traits are not needed because they are already included in BalanceT trait
| handle.record_cost(GasCalculator::<Runtime>::weight_to_gas(consumed_weight))?; | ||
|
|
||
| // Record Substrate related costs | ||
| // TODO: Add `ref_time` when precompiles are benchmarked |
Author
There was a problem hiding this comment.
this was fixed by upstream frontier
| type SelfParaId = parachain_info::Pallet<Runtime>; | ||
| type SelfParaId = staging_parachain_info::Pallet<Runtime>; | ||
| type OutboundXcmpMessageSource = XcmpQueue; | ||
| type DmpMessageHandler = DmpQueue; |
Author
There was a problem hiding this comment.
DmpQueue replaced by MessageQueue
paritytech/polkadot-sdk#1246
| mod version_tests; | ||
| mod xcm_mock; | ||
| mod xcm_tests; | ||
| // TODO: uncomment this once we are using deps from crates.io |
Author
There was a problem hiding this comment.
orml crates use deps from crates.io which causes version mismatch between polkadot-sdk deps and causes xcm-tests to fail. Generic refactor of xcm tests is needed:
- remove dependency on
ormlcrates - replace usage of
DmpQueuewithMessageQueue, see above why
|
|
||
| /// Means for transacting assets on this chain. | ||
| pub type LocalAssetTransactor = CurrencyAdapter< | ||
| pub type LocalAssetTransactor = FungibleAdapter< |
Author
There was a problem hiding this comment.
CurrencyAdapter replaced by FungiblesAdapter
paritytech/polkadot-sdk#3287
ghost
marked this pull request as ready for review
ghost
self-assigned this
ghost
marked this pull request as draft
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
paritytech/polkadot-sdk@release-polkadot-v1.1.0...release-polkadot-v1.6.0
polkadot-evm/frontier@polkadot-v1.1.0...polkadot-v1.6.0
Notable changes
cumulus-parachain-templateunless commented otherwise