Replace KeytabTable with KeytabTableWithFilter

[veronnicka]

The goal is to replace all KeytabTables with KeytabTableWithFilter

Refs: #763

Summary by Sourcery

Replace the legacy KeytabTable with the new KeytabTableWithFilter in the AllowedCreateKeytab component, wiring up filtered entry lists and RPC mutations with loading state for add/remove operations

Enhancements:

• Swap out KeytabTable for KeytabTableWithFilter across user, group, host, and hostgroup tabs
• Introduce modalSpinning state and useUpdateKeyTabMutation to handle asynchronous allow/disallow actions
• Add toTableEntries helper to transform host attributes into TableEntry lists for the filterable tables
• Expose entryCount prop in KeytabTableWithFilter to enable correct pagination and filtering

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• The repeated transformation of host prop values into table entries (usersList, userGroupsList, etc.) could be memoized or abstracted into a custom hook to avoid unnecessary recomputation on each render.
• The addEntries and removeEntries callbacks share nearly identical logic—consider refactoring them into a shared helper or hook to reduce duplication and improve readability.
• Moving static constants like allowMethod, disallowMethod, and the toTableEntries function outside the component body would prevent them from being recreated on every render.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The repeated transformation of host prop values into table entries (usersList, userGroupsList, etc.) could be memoized or abstracted into a custom hook to avoid unnecessary recomputation on each render.
- The addEntries and removeEntries callbacks share nearly identical logic—consider refactoring them into a shared helper or hook to reduce duplication and improve readability.
- Moving static constants like allowMethod, disallowMethod, and the toTableEntries function outside the component body would prevent them from being recreated on every render.

## Individual Comments

### Comment 1
<location> `src/components/HostsSections/AllowedCreateKeytab.tsx:23` </location>
<code_context>

 const AllowedCreateKeytab = (props: PropsToAllowCreateKeytab) => {
   const [activeTabKey, setActiveTabKey] = React.useState<string | number>(0);
+  const [modalSpinning, setModalSpinning] = React.useState<boolean>(false);
+  const [executeUpdate] = useUpdateKeyTabMutation({});
+
</code_context>

<issue_to_address>
Consider handling errors in async RPC calls to avoid silent failures.

addEntries and removeEntries only reset the spinner and refresh on success, but do not handle errors from executeUpdate. If the RPC call fails, the spinner may remain active and the user will not be notified. Please add error handling to reset the spinner and inform the user of failures.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[duzda]

Hi, apart from the notes, I'd add Refs: #763 to the commit message.

[duzda]

Please add the KeytabFields to the Host interface, see inline comments.
The type should be optional.

You might want to take a look at all the examples, there's also AllowedRetrieveKeytab, for Hosts and Services, I think all of these can be nicely squashed into one single component.

[veronnicka]

Bug introduced: adding host, it shouldnt who server.ipa.demo in the modal. Waiting for integration tests with this pr

[github-actions]

This PR has not received any attention in 60 days.

[carma12]

Removed the stale tag as this is under WIP.

[github-actions]

This PR has not received any attention in 60 days.