Skip to content

Conversation

@rjeffman
Copy link
Member

@rjeffman rjeffman commented Oct 21, 2025

After a PKI update the message returned for 'cert_show' in the case of an inexistent certificate has changed, causing tests to fail.

The fix is only required for the tests, as the behavior has not changed.

Summary by Sourcery

Tests:

  • Use regex in failed_when checks to match the new "Certificate ... not found" message pattern alongside 404 errors

After a PKI update the message returned for 'cert_show' in the case of
an inexistent certificate has changed, causing tests to fail.

The fix is only required for the tests, as the behavior has not changed.

Signed-off-by: Rafael Guterres Jeffman <[email protected]>
@rjeffman rjeffman requested a review from t-woerner October 21, 2025 18:32
@rjeffman rjeffman added the Candidate Good candidate for next minor release. label Oct 21, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rjeffman
Copy link
Member Author

Lint failures are handled in PR #1380

Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-woerner t-woerner merged commit 7036fa3 into freeipa:master Nov 10, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Candidate Good candidate for next minor release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants