Fixes ipahost idempotence issues

[rjeffman]

Fixes: #1296

Summary by Sourcery

Improve idempotence in the ipahost module by normalizing input values uniformly and refactoring host entry processing.

Bug Fixes:

• Fix idempotence issues by normalizing host parameters (case, FQDN, SSH keys) before comparison and ignoring unsupported updatedns settings

Enhancements:

• Refactor ipahost module to use EntryFactory for streamlined parameter conversion and entry iteration
• Add conversion helpers (lowercase, uppercase, unique FQDN, SSH public key normalization) in ansible_freeipa_module
• Update compare_args_ipa to include key context in debug messages and ignore updatedns during modifications
• Refactor ipasudorule to use unique FQDN conversion for host entries

Tests:

• Add integration tests to verify idempotence of mac_address casing and repeated host definitions in ipahost

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• The new single_host flag logic (single_host=len(entry_factory)>1) no longer matches the original hosts is None semantics—please verify it still produces the intended batching behavior when processing multiple entries.
• There’s still duplicated logic for splitting FQDN into host and domain in the DNS record sections—extracting that into a helper would reduce code repetition and minimize edge‐case bugs.
• Even with the EntryFactory, the main function is extremely large; consider breaking out host command generation for each state/action into helper functions to improve readability and maintainability.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The new single_host flag logic (`single_host=len(entry_factory)>1`) no longer matches the original `hosts is None` semantics—please verify it still produces the intended batching behavior when processing multiple entries.
- There’s still duplicated logic for splitting FQDN into host and domain in the DNS record sections—extracting that into a helper would reduce code repetition and minimize edge‐case bugs.
- Even with the EntryFactory, the main function is extremely large; consider breaking out host command generation for each state/action into helper functions to improve readability and maintainability.

## Individual Comments

### Comment 1
<location> `plugins/modules/ipahost.py:658` </location>
<code_context>
                 result["result"]["randompassword"]


+def convert_sshpubkey(value):
+    """Ensure sshpubkey values are correct."""
+    if isinstance(value, list):
+        value = [str(normalize_sshpubkey(key)) for key in value]
+    if isinstance(value, (str, unicode)):  # pylint: disable=E0606
+        value = str(normalize_sshpubkey(value))
+    return value
+
+
</code_context>

<issue_to_address>
convert_sshpubkey may not handle nested lists or None values robustly.

Please update convert_sshpubkey to handle None inputs and nested lists to prevent runtime errors.
</issue_to_address>

### Comment 2
<location> `plugins/module_utils/ansible_freeipa_module.py:540` </location>
<code_context>
     return value


+def convert_param_value_to_uppercase(value):
+    if isinstance(value, list):
+        value = [v.upper() for v in value]
+    if isinstance(value, (str, unicode)):
+        value = value.upper()
+    return value
+
+
</code_context>

<issue_to_address>
convert_param_value_to_uppercase does not handle None values.

Explicitly handle None to ensure consistent behavior and prevent unintended results in downstream code.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rjeffman]

Dowstream tests are passing with these changes.