Don't execute deployment roles if packages are not installed #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @rjeffman - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
rjeffman
force-pushed
the
ipaserver_state_absent_fail_uninstall
branch
from
cd398b2 to
7f30beb
Compare
rjeffman
force-pushed
the
ipaserver_state_absent_fail_uninstall
branch
from
7f30beb to
5054732
Compare
rjeffman
force-pushed
the
ipaserver_state_absent_fail_uninstall
branch
from
5054732 to
f028993
Compare
rjeffman
changed the title
When running the deployment roles, if packages are not installed, an error of a missing module is shown, which is confusing to users. By ensuring that either installation or uninstallation only work if a minimal set of tools is available allows to provide a meaningful message and let users act on the environment. For installation, if ipa-server/client-install is not available, the installation is aborted with a meaningful error. For uninstallation, we assume that IPA is not installed and gently finish the process with no errors. Signed-off-by: Rafael Guterres Jeffman <[email protected]>
rjeffman
force-pushed
the
ipaserver_state_absent_fail_uninstall
branch
from
f028993 to
0b4329c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the deployment roles, if packages are not installed, an
error of a missing module is shown, which is confusing to users.
By ensuring that either installation or uninstallation only work if a
minimal set of tools is available allows to provide a meaningful message
and let users act on the environment.
For installation, if ipa-server/client-install is not available, the
installation is aborted with a meaningful error. For uninstallation, we
assume that IPA is not installed and gently finish the process with no
errors.
ipareplicauninstall is not modified as it usesipaserverrole.Fix #1362