Merged
Conversation
553b89b to
ed1196c
Compare
If the entry is escaped, we'd need to mark every use of it in the templates as `| safe` which is more dubious than not escaping the database entry in the first place. Fixes #6357
ed1196c to
71a8b05
Compare
zenmonkeykstop
approved these changes
Sep 21, 2022
Contributor
zenmonkeykstop
left a comment
There was a problem hiding this comment.
Test plan checks out, made a couple of attempts to try SQL injections which were shrugged off by SQLAlchemy without fuss!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
If
InstanceConfig.organization_nameis escaped before writing it to the database, we'd need to mark every use of it in the templates as| safe, which is more dubious than not escaping the database entry in the first place.Fixes #6357
Testing
&s or ümläüts) and click Set Organization NameChecklist