Fix source_app.utils.normalize_timestamps

[rmol]

Status

Ready for review

Description of Changes

Upon each new submission, source_app.utils.normalize_timestamp is called to update the timestamps of all the source's submissions. It currently uses the touch command to do this, which means if a file has gone missing, it will be recreated empty. This could mask problems that would otherwise be detected by the daily check for disconnected submissions. The function is also omitting the most recent submission from the arguments, assuming that touch is going to give the previous submissions the same timestamp as the new one, which might not be true if it's not processed instantaneously.

This changes the function to call touch with the --no-create flag and all of the source's submissions.

Testing

• make dev
• Log in to the source interface as a new source. Submit one message.
• run docker exec -it securedrop-dev-0 bash
• in the container, navigate to the source's directory under /var/lib/securedrop/store and delete the file of the message you just submitted.
• Back in the source interface, submit another two messages, waiting a few seconds between them.
• Back in the container shell, verify that the source's directory only contains two files (2-... and 3-...) and that their timestamps match.

Deployment

No special considerations.

Checklist

If you made changes to the server application code:

• Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

Choose one of the following:

• I have opened a PR in the docs repo for these changes, or will do so later
• I would appreciate help with the documentation
• These changes do not require documentation

[lgtm-com]

This pull request introduces 1 alert when merging 7add4ce into cbcc894 - view on LGTM.com

new alerts:

• 1 for Unused import

[zenmonkeykstop]

Test plan passes, LGTM once CI is green

[codecov-io]

Codecov Report

Merging #5724 (dcb7551) into develop (cbcc894) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #5724   +/-   ##
========================================
  Coverage    85.58%   85.58%           
========================================
  Files           52       52           
  Lines         3773     3773           
  Branches       471      471           
========================================
  Hits          3229     3229           
  Misses         439      439           
  Partials       105      105           

Impacted Files	Coverage Δ
securedrop/source_app/utils.py	92.10% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbcc894...dcb7551. Read the comment docs.