Conversation
kushaldas
force-pushed
the
focal_ci
branch
2 times, most recently
from
November 9, 2020 13:26
c42f4aa to
f2dd714
Compare
This adds related CI steps for app tests on Focal
emkll
approved these changes
Nov 10, 2020
emkll
left a comment
Contributor
There was a problem hiding this comment.
Ci is passing and the docker caching is working in CI. LGTM
| paths: | ||
| - /caches/layers.tar | ||
|
|
||
| - &focalcreatecachedir |
Contributor
There was a problem hiding this comment.
we can probably re-use the same cache dir as for Xenial just specifying different layer files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5524
This adds related CI steps for app tests on Focal
Testing
Focal.Deployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
Choose one of the following:
If you added or updated a code dependency:
Choose one of the following: