Monkey-patch pretty-bad-protocol to work with Focal gnupg#5615
Merged
Monkey-patch pretty-bad-protocol to work with Focal gnupg#5615
Conversation
To work with recent gnupg, the pretty-bad-protocol package needs an update it seems unlikely to get, so we're gonna monkey-patch it until we can find a viable replacement. isislovecruft/python-gnupg#250
kushaldas
approved these changes
Nov 5, 2020
Contributor
There was a problem hiding this comment.
This is 🪄🪄🪄🪄
Testing
- CI should be green.
-
make test-focalshould pass. - In the source interface, submit a message and a file.
- Confirm that you can download those from the journalist interface and decrypt them.
- Send a reply to the source, and confirm that it's readable in the source interface.
Thank you @rmol for this. Focal has green CI.
Here 23 means 23 :: The key is compliant with compliance mode "de-vs". and de-vs is a German standard to handle secret information https://de.wikipedia.org/wiki/Verschlusssache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5592.
To work with recent gnupg, the pretty-bad-protocol package needs an update it seems unlikely to get, so we're gonna monkey-patch it until we can find a viable replacement.
isislovecruft/python-gnupg#250
Testing
make test-focalshould pass.Deployment
This modifies the unmaintained library we're using for encrypting submissions and replies so that it will work on Focal. It shouldn't negatively affect Xenial.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes:
Choose one of the following: