Fix test_rm.py::test_secure_delete_capability#5614
Merged
Conversation
When testing what happens when the shred command is not found, the PATH environment variable shouldn't contain any location where it could ever exist, as just happened in the upgrade from Xenial to Focal. The test script also had a typo.
kushaldas
approved these changes
Nov 4, 2020
Contributor
kushaldas
left a comment
kushaldas
left a comment
There was a problem hiding this comment.
Code change looks good. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
When testing what happens when the
shredcommand is not found, thePATHenvironment variable shouldn't contain any location where it could ever exist, as just happened in the upgrade from Xenial to Focal. The test script also had a typo.Testing
CI should be green.
Deployment
Test only.
Checklist
Choose one of the following: