Fixes #5522 no typing module required on Focal#5527
Merged
Conversation
We need the typing module only on Xenial, but not on Focal.
zenmonkeykstop
approved these changes
Sep 24, 2020
emkll
approved these changes
Oct 1, 2020
Contributor
emkll
left a comment
There was a problem hiding this comment.
Inspected both xenial and focal packages produced by this branch, typing is included in the xenial virtualenv shipped by the built package, and not in the one shipped in the focal package.
Systemctl units are not failing in focal, and CI is green 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5522
We need the typing module only on Xenial, but not on Focal.
Testing
make build-debs-focal && molecule converge -s libvirt-staging-focalDeployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: