Make qa_loader.py nicer for load and workstation testing#5174
Merged
zenmonkeykstop merged 3 commits intodevelopfrom Apr 17, 2020
Merged
Make qa_loader.py nicer for load and workstation testing#5174zenmonkeykstop merged 3 commits intodevelopfrom
zenmonkeykstop merged 3 commits intodevelopfrom
Conversation
This version: - generates legible names, messages, and replies - generates recent dates - generates source keys - permits specification of exact numbers: - of journalists and sources - number of submissions and replies per source - fraction of sources starred - fraction of sources replied to The resulting database produces sensible API results, so functions better for testing the SecureDrop Workstation.
zenmonkeykstop
force-pushed
the
qa-loader-overhaul
branch
from
25adde2 to
e3ad82e
Compare
kushaldas
approved these changes
Apr 15, 2020
Contributor
kushaldas
left a comment
kushaldas
left a comment
There was a problem hiding this comment.
Approving from my side, I will wait for someone else to have a second look, and then merge.
Contributor
|
Also LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This version:
The resulting database produces sensible API results, so functions better for testing the SecureDrop Workstation.
Testing
Create a staging environment from this branch. Populate it with the new
qa_loader.pyand confirm that the resulting data counts match your specifications.Deployment
Dev only.
Checklist
If you made non-trivial code changes: