gettext calls containing formatted strings produce untranslated text

[rmol]

Description

There are a few places where we do gettext('something about {}'.format('blah')) instead of gettext('something about {}').format('blah') and the misplaced .format call has gettext looking for the formatted string in the message catalogs. When it can't be found, English appears in the user interface.

Steps to Reproduce

• make dev
• visit the JI admin interface, choose a language other than English, and add a user or edit dellsberg.
• try to change the first name to something longer than 100 characters.

Expected Behavior

The flashed error message should be in the selected language.

Actual Behavior

It's in English.

Comments

There are at least these occurrences:

• securedrop/securedrop/journalist_app/admin.py

  Line 139 in 7f4076b

  flash(gettext('Username "{user}" already taken.'.format(

• securedrop/securedrop/journalist_app/admin.py

  Line 239 in 7f4076b

  flash(gettext('Name not updated: {}'.format(e)), "error")

• securedrop/securedrop/journalist_app/admin.py

  Line 247 in 7f4076b

  flash(gettext('Name not updated: {}'.format(e)), "error")

• securedrop/securedrop/journalist_app/utils.py

  Line 368 in 7f4076b

  flash(gettext('Name not updated: {}'.format(e)), "error")