Remove v2 onion service support; fix Whonix repo list filename

[eloquence]

Status

Ready for review

Description of Changes

Fixes #692
Fixes #693

• Removes support for v2 onion services (we don't even recognize the format anymore - cue Phil Collins "No Son of Mine")
• Updates Whonix repo list filename to ensure tests pass

Testing

Estimated testing time: 30-60 minutes

1. make clone this branch into dom0 and sudo dnf reinstall (or make staging if you don't have a previously provisioned environment) the freshly built RPM from rpm-build/RPMS/noarch.
2. Attempt to update your /usr/share/securedrop-workstation-dom0-config/config.json with a v2 config (contents of config.json.example in current main should do) and run sdw-admin --apply
3. • Observe moderately helpful error message & script exiting
4. Now put in something that looks nothing like a v2 or v3 config for the hostname and key options (e.g., random characters), and re-run sdw-admin --apply
5. • Observe same error message
6. Put in a v3 config and run sdw-admin --validate (or --apply if you are patient)
7. • Observe success
8. Make sure your currently provisioned config.json and sd-journalist.sec are present in your securedrop-workstation checkout directory in dom0, then run make test
9. • Observe tests passing (or at least that test failures are unrelated to this PR - dom0 tests can be a bit finicky)

If you have made changes to the provisioning logic

• All tests (make test) pass in dom0 of a Qubes install

[eloquence]

securedrop.org website onion service

[eloquence]

randomly generated key in base32

[eloquence]

IMO this script shouldn't display tracebacks during expected validation errors, but that's the current pattern. See #683 as well for suggested refactoring of this whole logic.

[eloquence]

That's what fixes #693

[conorsch]

Looks great. I found one more place in the tests where updating the repo filepath makes sense:

diff --git a/tests/test_proxy_vm.py b/tests/test_proxy_vm.py
index 37e84c8..989c620 100644
--- a/tests/test_proxy_vm.py
+++ b/tests/test_proxy_vm.py
@@ -63,7 +63,9 @@ class SD_Proxy_Tests(SD_VM_Local_Test):
         Guard against regressions by ensuring the old Whonix apt list
         is missing.
         """
+        # Whonix project changed the repo filename ~2021-05, so check both.
         assert not self._fileExists("/etc/apt/sources.list.d/whonix.list")
+        assert not self._fileExists("/etc/apt/sources.list.d/derivative.list")
 
     def test_logging_configured(self):
         self.logging_configured()

Will amend as part of review.