Removes migration flag from postinst#667
Merged
sssoleileraaa merged 1 commit intomainfrom Apr 8, 2021
Merged
Conversation
Contributor
Author
|
I say "partially reverts" because I left the diff here https://github.com/freedomofpress/securedrop-workstation/pull/661/files#diff-6aca08490233cea9eacc7a2099a4e4d8bb404d7018cd3efac3b42ef3ef99d30dL29-L31 Seemed like we're likely to want to do this again, via postinst, so let's not block ourselves unnecessarily. |
Partially reverts 6cf625c. Disables the automatic creation of a migrate-everything ask of the GUI updater. We only want that migration to run once, so let's remove the postinst task prior to the next prod release.
conorsch
force-pushed
the
remove-migration-flag-from-postinst
branch
from
cfb8e2a to
9507beb
Compare
Contributor
Author
|
Rebased on top of latest main, to pull in changes from #666. |
sssoleileraaa
approved these changes
Apr 8, 2021
Contributor
sssoleileraaa
left a comment
sssoleileraaa
left a comment
There was a problem hiding this comment.
I tested by building the RPM, reinstalling it in dom0 and saw that the migration flag and dir are no longer there
cfm
pushed a commit
that referenced
this pull request
Apr 1, 2024
…m-postinst Removes migration flag from postinst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Partially reverts 6cf625c.
Disables the automatic creation of a migrate-everything ask of the GUI
updater. We only want that migration to run once, so let's remove the
postinst task prior to the next prod release.
Testing
How should the reviewer test this PR?
Write out any special testing steps here.
Checklist
If you have made code changes
make flake8) passes in the development environment (this box maybe left unchecked, as
flake8also runs in CI)If you have made changes to the provisioning logic
All tests (
make test) pass indom0of a Qubes installThis PR adds/removes files, and includes required updates to the packaging
logic in
MANIFEST.inandrpm-build/SPECS/securedrop-workstation-dom0-config.spec