Conversation
Use of the discover subcommand for test discovery ensures the "base" module is correctly imported.
emkll
approved these changes
Nov 5, 2020
Contributor
There was a problem hiding this comment.
Thanks @eloquence, confirmed that I can reproduce the issue and that all test targets are now working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #622
Use of the
discoversubcommand for test discovery ensures the "base" module is correctly imported.Testing
make test-baseindom0without the changes in this PRmake cloneagainst this branch, then run the individual subtargets for tests declared in the Makefile.Checklist
make test) pass indom0of a Qubes installlogic in
MANIFEST.inandrpm-build/SPECS/securedrop-workstation-dom0-config.spec