Show reboot when no updates are required (and user did not reboot)

[emkll]

Status

Ready for review

Description of Changes

Fixes #435

Testing

More updates scenario

• All other VMs are up-to-date
• Ensure your fedora-30 template needs an update (sudo dnf downgrade zlib)
• run the updater, apply updates, and close the updater (click cancel button)
• downgrade a non-reboot-after-update-vm (eg, sd-app-buster-template but not fedora-30 nor dom0) by downgrading a package
• run the updater, and observe the reboot is requested after the updates are applied to sd-app-buster-template

Up-to-date scenario

• All other VMs are up-to-date
• Ensure your fedora-30 template needs an update (sudo dnf downgrade zlib)
• run the updater, apply updates, and close the updater (click cancel button)
• run the updater again, observer reboot screen after checking for updates

[kushaldas]

• Run for the first time, I was required a few updates
• after update & reboot
• After reboot, it says more update needed, asked to reboot again, rebooted.
• finally, no more reboot option
• Downgraded zlib in the Fedora 30, now the updater asked to update
• asked for a reboot (this should not happen).

[emkll]

@kushaldas that is expected behavior: by design, any update to fedora-30 will require a reboot. We could file a follow-up to reboot the sys-{usb,net,firewall} after updating the fedora template but the order might be complicated and would disrupt user actions should they be doing something else on the Workstation.

the test plan states:

downgrade a non-reboot-after-update-vm (sd-app-buster-template) by downgrading a package

I have clarified the test plan to explicitly exclude fedora-30

[kushaldas]

I was testing based on

    - All other VMs are up-to-date
     -Ensure your fedora-30 template needs an update (sudo dnf downgrade zlib)
    - run the updater, apply updates, and close the updater
    - run the updater again, observer reboot screen after checking for updates

I never understood that close the updater means, close the application even when the updater said "reboot". This explains better now.

[emkll]

ahh yes, sorry that was unclear @kushaldas . "close the updater" can be done by clicking the "cancel" button. Updated the test plan, sorry for the confusion

[redshiftzero]

thanks @emkll! lgtm and test plan all works as advertised

@kushaldas you can either dismiss your review if you're happy with this as is and merge else if you also want to do a full review feel free

test plan updated.

[kushaldas]

Worked good. Approved.