Change JSON key "last_updated" in sdw-update-flag to "last_status_update"

[eloquence]

The use of last_updated here is ambiguous with with the usage in the separate file sdw-last-udpated, which contains the time of the last successful update of the SecureDrop Workstation.

The last_updated key in sdw-last-updated contains the timestamp of the last time the status itself was written to disk, regardless of success or failure.

I have also renamed the file itself to sdw-update-status for clarity, since that is the purpose of the file.

Status

Ready for review

Testing

• Tests should still pass
• Verify that the status file is written as expected to sdw-update-status when running the updater
• Verify that make clean removes file under old name

[eloquence]

Personally I think sdw-update-status would be a more self-explanatory name for the flag file, unless we're future-proofing it in some way by calling it "flag", and I'd be happy to rename it if that sounds reasonable (it's not used for anything yet), but for now focused on just addressing the dueling use of last_updated which I found very confusing, and which @emkll agreed would be reasonable to tweak.

[eloquence]

Per brief chat at standup, renamed the file as well; leaving in draft for now until I give it one quick run-through in Qubes.

[eloquence]

Tested in Qubes, works as expected.

[emkll]

Diff and functional testing looks good to me.
The only issue that should be addressed before merge, IMO, should be a clean up of all the dom0 flags (see inline).

While testing this pr, I discovered an related but not related bug. If you think it makes sense to take a stab at fixing this, that would be great otherwise I will open a follow up.

The reboot_required case should be handled at this point and show the reboot button

securedrop-workstation/launcher/sdw_updater_gui/UpdaterApp.py

Line 113 in 87b2c61

else:

.

str:

• apply updates that require a reboot
• close app
• open app (no updates required), error is shown (because REBOOT_REQUIRED case is not handled, and is part of the catch-all)

[emkll]

We should at least remove the other flags as well (the current, working flags) and consider deleting the entire folder (which include the logs)

[eloquence]

I was wondering about that; I thought you maybe intentionally omitted the folder. But I agree, it should clean up everything.

[eloquence]

Done and tested. If you prefer to preserve the logs we can list individual files instead, but it would feel a bit wrong to me to leave this directory hanging around after a make clean.

[eloquence]

The reboot_required case should be handled at this point and show the reboot button

I'll file a separate issue for that, thanks for the clear STR

[emkll]

thanks @eloquence , lgtm