When running the clean makefile target [1] (or the associated prod securedrop-admin target [2]), the operation will stop as soon as an error occurs. This means that the workstation is in a potentially unpredictable state, and some cleanup operations may not complete.
For example, in the case of functionality added #533, the custom tags are removed after vms are destroyed, if a Template is not destroyed due to an error ( for example TemplateVM used by an unmanaged AppVM), the tags will not be removed.
Since it is inherently destructive operation we should consider ignoring errors at runtime and continue execution, and report errors at the end
[1]
[2]
When running the clean makefile target [1] (or the associated prod securedrop-admin target [2]), the operation will stop as soon as an error occurs. This means that the workstation is in a potentially unpredictable state, and some cleanup operations may not complete.
For example, in the case of functionality added #533, the custom tags are removed after vms are destroyed, if a Template is not destroyed due to an error ( for example TemplateVM used by an unmanaged AppVM), the tags will not be removed.
Since it is inherently destructive operation we should consider ignoring errors at runtime and continue execution, and report errors at the end
[1]
securedrop-workstation/Makefile
Line 110 in 079ff4e
[2]
securedrop-workstation/scripts/securedrop-admin.py
Line 98 in 079ff4e