Skip to content

Remove HTTP links and check for new ones as part of the linting process#777

Merged
ChumOfChance merged 1 commit intomainfrom
improve-linting
Mar 5, 2026
Merged

Remove HTTP links and check for new ones as part of the linting process#777
ChumOfChance merged 1 commit intomainfrom
improve-linting

Conversation

@nathandyer
Copy link
Contributor

@nathandyer nathandyer commented Mar 4, 2026

This PR removes HTTP links where not required as either part of .onion names, or part of XML specs.

It also adds a check to the linter to make sure any new HTTP links are immediately flagged.

Test plan

  • Try modifying the docs to add an http-only link.
  • Ensure that the linter throws an error
  • Change the link to HTTPS and ensure the linter is happy again
  • Visual review
  • CI passes

@nathandyer nathandyer moved this to Ready For Review in SecureDrop Mar 4, 2026
@nathandyer nathandyer requested a review from ChumOfChance March 5, 2026 17:04
@ChumOfChance ChumOfChance added this pull request to the merge queue Mar 5, 2026
@ChumOfChance
Copy link
Contributor

Approved and merged. Some additional action will be needed to pick this change and apply it to the current live documentation.

Merged via the queue into main with commit 174ecf2 Mar 5, 2026
2 checks passed
@ChumOfChance ChumOfChance deleted the improve-linting branch March 5, 2026 21:19
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in SecureDrop Mar 5, 2026
@@ -5,8 +5,8 @@
this by squashing closely related commits through an interactive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is used anywhere anymore? Certainly there should be nothing about squashing in this set of docs, maybe it's leftover from the dev-docs split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants