Skip to content

Add image build workflow for publishing container images to Github packages#725

Merged
legoktm merged 6 commits intomainfrom
enp/github
Oct 22, 2025
Merged

Add image build workflow for publishing container images to Github packages#725
legoktm merged 6 commits intomainfrom
enp/github

Conversation

@enpaul
Copy link
Copy Markdown
Contributor

@enpaul enpaul commented Oct 2, 2025

Fixes #703

Test plan

N/a

Checklist

N/a

@enpaul
Copy link
Copy Markdown
Contributor Author

enpaul commented Oct 2, 2025

Note that this PR will require an update to the required checks (the "build" job has been renamed) so that it passes CI

@legoktm legoktm self-assigned this Oct 3, 2025
@legoktm legoktm moved this to Blocked or Waiting in SecureDrop Oct 3, 2025
@redshiftzero
Copy link
Copy Markdown
Contributor

Blocked due to CI failing, @enpaul taking a look

Copy link
Copy Markdown
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing

Comment thread .github/workflows/publish.yaml
@legoktm legoktm moved this from Blocked or Waiting to Under Review in SecureDrop Oct 21, 2025
@enpaul enpaul requested a review from legoktm October 21, 2025 22:54
legoktm
legoktm previously approved these changes Oct 22, 2025
Copy link
Copy Markdown
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I assume you can take care of the CI required jobs needing to be renamed

legoktm
legoktm previously approved these changes Oct 22, 2025
@enpaul enpaul added this pull request to the merge queue Oct 22, 2025
@legoktm
Copy link
Copy Markdown
Member

legoktm commented Oct 22, 2025

Oh because there's a more restrictive push filter, we need the explicit merge_group checks...give me a minute.

Needed because we now have a more restrictive push filter.
@legoktm legoktm removed this pull request from the merge queue due to a manual request Oct 22, 2025
@legoktm legoktm enabled auto-merge October 22, 2025 20:54
@legoktm legoktm added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit c728897 Oct 22, 2025
3 checks passed
@legoktm legoktm deleted the enp/github branch October 22, 2025 21:02
@github-project-automation github-project-automation Bot moved this from Under Review to Done in SecureDrop Oct 22, 2025
@nathandyer nathandyer removed this from SecureDrop Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add image build workflow for building+publishing images to Github Packages

4 participants