Adds new functional test to login from offline mode#983
Merged
sssoleileraaa merged 1 commit intomasterfrom Mar 24, 2020
Merged
Conversation
kushaldas
force-pushed
the
login_from_offline
branch
2 times, most recently
from
8640695 to
ad64311
Compare
sssoleileraaa
force-pushed
the
login_from_offline
branch
2 times, most recently
from
b22c178 to
c14e6be
Compare
sssoleileraaa
previously approved these changes
Mar 24, 2020
| qtbot.mouseClick(gui.login_dialog.submit, Qt.LeftButton) | ||
|
|
||
| def wait_for_login(): | ||
| assert gui.login_dialog is None |
Contributor
There was a problem hiding this comment.
✔️ this test successfully checks that the login dialog goes away after a user is logged in
Fixes #980 It first logs in, and then logsout, and then log in again.
sssoleileraaa
force-pushed
the
login_from_offline
branch
from
c14e6be to
4e61e5f
Compare
sssoleileraaa
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #980
It first logs in, and then logsout, and then log in again.
Test Plan
make test-functionalworksChecklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: