Adjust the clickable area for logging out to include the user's icon.

[ntoll]

Description

Towards #285.

Screenie of modified behaviour:

Took a while to work out the simplest / easiest approach. But in the end I just created a child class from QLabel which emitted click events and connected the emitted click to the button with the menu.

Test Plan

Added unit test.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

• I have tested these changes in the appropriate Qubes environment
• I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
• These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

• I have submitted a separate PR to the packaging repo
• No update to the packaging logic (e.g., AppArmor profile) is required for these changes
• I don't know and would appreciate guidance

[kushaldas]

This looks good, I think you should also add a functional test here :)

[redshiftzero]

Requesting UX feedback from @ninavizz / @eloquence on this one - this PR seems like a concrete improvement to me as it includes the initials in the clickable region. It does not fully close #285 yet as the region around the initials/name in this image is not yet clickable and we haven't yet customized the dropdown menu. We can merge this as an improvement (for pilot beta) or we can wait for the complete behavior in #285 to be implemented (might not make it to first pilot beta). Thoughts? My preference is for the former, but we leave #285 open for further work.

[eloquence]

IMO this is a valuable iterative improvement and should be merged without resolving #285 just yet.

[redshiftzero]

hey @kushaldas, I opened #980 to follow up on your comment here, since I want to merge this for the beta pilot

see my comment above