Update login UI messages per UI messages audit#903
Merged
Conversation
e897fa3 to
766bc39
Compare
83abb7e to
daf714f
Compare
Contributor
Author
|
@ninavizz and I screen-shared this in Qubes (using fancy new Qubes screen-shairng setup ;-) and she has signed off on these changes. We'd like to do a bit more polish on the error bar in future, to give it more breathing room for longer messages, but that can be done post-beta or in a small follow-up PR. |
daf714f to
444cb84
Compare
redshiftzero
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Part of #53. Makes error messages a bit more consistent and (hopefully) friendly:
Switches the error bar to SecureQLabel as apostrophes were otherwise displayed incorrectly.
Updates the version string as previously discussed here.
Test plan
Checklist
Screenshots
Click to expand