undo changes to adding a reply to the gui#295
Merged
Merged
Conversation
sssoleileraaa
force-pushed
the
issue-289-fix
branch
from
b117671 to
716f3f5
Compare
sssoleileraaa
force-pushed
the
issue-289-fix
branch
from
716f3f5 to
9381fe2
Compare
emkll
approved these changes
Apr 4, 2019
Contributor
emkll
left a comment
emkll
left a comment
There was a problem hiding this comment.
I can reproduce the issue described in master`:
Traceback (most recent call last):
File "/home/user//src/securedrop-client/securedrop_client/gui/widgets.py", line 948, in send_reply
self.conversation.send_reply(msg)
File "/home/user/src/securedrop-client/securedrop_client/gui/widgets.py", line 900, in send_reply
self.conversation.add_reply(msg_uuid, message)
TypeError: add_reply() takes 2 positional arguments but 3 were given
The changes introduced in this branch fix the issue and replies can be sent successfully:
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289
/cc @heartsucker or @rmol