Merged
Conversation
Contributor
|
While attempting to review this, I ran into an issue on the "Checking that SHA256SUMs from mirror match signed file" step where it fails on |
Contributor
|
Nevermind, I posted that comment too soon because I got tired of trying different |
sssoleileraaa
approved these changes
Apr 9, 2021
Contributor
sssoleileraaa
left a comment
There was a problem hiding this comment.
This works fine in Qubes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our virtualenv is based on Python 3.7, so this path does not in fact exist on the
sd-appVM.Note that this is an informational finding from the 2020 SecureDrop Workstation audit (
TOB-SDW-013). Per the finding, the correct path already exists insys.pathat the time the incorrect path is inserted.Test Plan
sd-app.securedrop_clientdirectory insd-appChecklist