Skip to content

When finding new files/messages/replies, work back in time#1043

Merged
sssoleileraaa merged 1 commit intomasterfrom
source-list-population-order
Apr 2, 2020
Merged

When finding new files/messages/replies, work back in time#1043
sssoleileraaa merged 1 commit intomasterfrom
source-list-population-order

Conversation

@rmol
Copy link
Contributor

@rmol rmol commented Apr 1, 2020

Description

Retrieving submissions and replies for the most recently active sources first will make the initial sync feel faster, as the visible part of the source list is updated first, and will make it possible to for journalists to work with what are likely the most interesting sources sooner.

Fixes #1042.
Fixes #883.

Test Plan

  • Check out this branch.
  • Run the dev server with NUM_SOURCES=20.
  • Start the client. The sources at the top of the list should have their messages and replies populated first. You should be able to see the progress of the sync as it works down through the source list (unfortunately, retrieving the individual submissions and replies is still that slow).

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

@rmol rmol force-pushed the source-list-population-order branch from ae0ea21 to 8317e2a Compare April 2, 2020 19:19
sssoleileraaa
sssoleileraaa previously approved these changes Apr 2, 2020
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Retrieving submissions and replies for the most recently active
sources first will make the initial sync feel faster, as the visible
part of the source list is updated first, and will make it possible to
for journalists to work with what are likely the most interesting
sources sooner.
@sssoleileraaa sssoleileraaa merged commit 8934a55 into master Apr 2, 2020
@sssoleileraaa sssoleileraaa deleted the source-list-population-order branch April 2, 2020 21:59
@redshiftzero redshiftzero mentioned this pull request May 7, 2020
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Populate active source conversations first Show decrypted text for the first source in the SourceList first

2 participants