Tracking upstream issue QTBUG-85498

[sssoleileraaa]

Description

This is an issue to track upstream issue: https://bugreports.qt.io/browse/QTBUG-85498

We use QLabels in various places, including our message and reply speech bubbles. QLabel provides a wrapping feature but does not automatically wrap strings that are longer than the width of the label and contains no spaces, dashes, and other unknown wrapping-point characters (wrapping points are not documented or specified in the Qt code so it's a bit of an unknown).

More info

QLabel knows to wrap based on the length of a line of text and where the nearest wrapping-point character is within the bounds of the width of the label. Unfortunately, there isn't Qt support to adjust the wrapping policy to say that we prefer wrapping over cutting off strings that don't contain wrapping points.

We've learned that QTextEdit and QPlainTextEdit support the kind of wrapping we are interested in by default, however as you can see in #1050 there is the problem with recalculating and setting the height of a QTextEdit to fit the contents of its internal document.

Test data can be found here: https://github.com/freedomofpress/securedrop-client/wiki/Test-plan#input-testing

[sssoleileraaa]

I think the desired behavior is to use word wrapping over a horizontal scrollbar

[eloquence]

Marked as release blocker due to information loss from the user's perspective.

[eloquence]

Pulled into current sprint per discussion on #799.

[ntoll]

I've been able to reproduce. I suspect a word-wrap strategy flag needs to be set to the appropriate value. Will try to get as close to @creviera's suggestion as possible in coming up PR. 👍

[ntoll]

Hmmm... https://doc.qt.io/qt-5/qlabel.html#wordWrap-prop :-(

It looks like Qt's default word-wrap only works on whitespace, not as @creviera specifies. However, I notice (see screenie) that if I setWordWrap(True) on the QLabel in our SpeechBubble widget I notice that things do start to wrap on a "-" character, giving rise to the possibility that if there is a single word > X characters (where X is our current max char width) then we insert a "-" at that point so Qt's word-wrapping kicks in. I'll code up this approach into a PR.

[ntoll]

FWIW, this also effects summary and messages too:

[ntoll]

Thank you St.Guido van Rossum: https://docs.python.org/3.8/library/textwrap.html

[eloquence]

Reopening per findings in #998.