Add ConfigureAwait(false) to library async calls

[Copilot]

Library code was missing ConfigureAwait(false) on await statements, causing unnecessary synchronization context capture.

Changes

Added ConfigureAwait(false) to all 7 await statements in library code:

BaseApi.cs (5 locations):

• Authentication flow: ApplyAuthenticationAsync, ApplyEntraIdAuthenticationAsync
• Token acquisition: GetAccessTokenAsync
• HTTP execution with retry policy (outer + inner lambda)

ApiTokenProvider.cs (2 locations):

• Credential acquisition: GetTokenCredentialAsync
• Token request: GetTokenAsync

Example

// Before
var credential = await tokenCredentialProvider.GetTokenCredentialAsync(cancellationToken);
var tokenResult = await credential.GetTokenAsync(context, cancellationToken);

// After
var credential = await tokenCredentialProvider.GetTokenCredentialAsync(cancellationToken).ConfigureAwait(false);
var tokenResult = await credential.GetTokenAsync(context, cancellationToken).ConfigureAwait(false);

Notes

• ClientCredentialProvider and DefaultTokenCredentialProvider correctly use Task.FromResult (no await needed)
• RestClientService delegates to RestSharp (no await needed)
• CancellationToken already properly threaded throughout

Original prompt

Task: Perform a targeted code review of the provided repository/files focusing strictly on Asynchronous Best Practices and TPL (Task Parallel Library) efficiency and perform required remediation.

​Constraints:

• ​No Feature Changes: Do not alter business logic, variable names (unless necessary for clarity), or application behavior.
• ​Consistency: Apply a uniform pattern across the entire selection.
• ​No Blocking: Identify and remove all instances of sync-over-async (e.g., .Result, .Wait(), .GetAwaiter().GetResult()).

​Review Checklist & Remediation Rules:

• ​Async All the Way: Ensure Task or ValueTask propagates from the entry point down to the I/O call.
• ​ValueTask Optimization: Suggest ValueTask or ValueTask for methods that frequently complete synchronously to reduce heap allocations.
• ​Cancellation Tokens: Ensure CancellationToken is passed through all asynchronous method signatures and honored in I/O calls.
• ​ConfigureAwait: Unless this is UI-bound code (WPF/WinForms), apply .ConfigureAwait(false) consistently to prevent context capture overhead.
  ​Resource Management: Ensure await using is used for IAsyncDisposable types.
• ​Task Overheads: Avoid Task.Run for I/O-bound work; use it only for CPU-bound offloading.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[frasermolyneux]

@copilot - Perform another pass to perform a targeted code review of the provided repository/files focusing strictly on Asynchronous Best Practices and TPL (Task Parallel Library) efficiency and perform required remediation. The same constraints and approach apply. If no further changes are required state as such.

[Copilot]

@copilot - Perform another pass to perform a targeted code review of the provided repository/files focusing strictly on Asynchronous Best Practices and TPL (Task Parallel Library) efficiency and perfo...

Completed comprehensive async/await review. No further changes required.

Review Results

✅ All async/await best practices are properly implemented:

1. ConfigureAwait(false): All 7 await statements use it correctly
2. No blocking calls: No .Result, .Wait(), or .GetAwaiter().GetResult() in production code
3. CancellationToken: Properly threaded through all async methods
4. No Task.Run misuse: No unnecessary Task.Run for I/O operations
5. No async void: All async methods return Task or Task
6. Exception propagation: Proper exception handling throughout

Optional Optimization Identified (Not Implemented)

ValueTask<T> could be used in credential providers (DefaultTokenCredentialProvider, ClientCredentialProvider) since they complete synchronously via Task.FromResult(). However:

• Would be a breaking API change to ITokenCredentialProvider interface
• Minimal benefit due to low call frequency (token cached ~5 minutes)
• Not worth the breaking change for v2.x

Recommendation: Consider for v3.0 if major version bump planned.

Commit: 1f59d96

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud