feat(fileupload): added toast for file upload size limit error#575
Open
raizasafeel wants to merge 1 commit intofrappe:mainfrom
Open
feat(fileupload): added toast for file upload size limit error#575raizasafeel wants to merge 1 commit intofrappe:mainfrom
raizasafeel wants to merge 1 commit intofrappe:mainfrom
Conversation
pateljannat
reviewed
Feb 9, 2026
| this.error = errorMessage | ||
|
|
||
| // Show toast only for file size limit errors, console log others | ||
| if (error?.httpStatus === 413) { |
Member
There was a problem hiding this comment.
Maybe toast and console.error should be shown for all types of errors. In other cases too, if we just show console.error, the end user gets no idea that something is failing.
|
|
||
| // Show toast only for file size limit errors, console log others | ||
| if (error?.httpStatus === 413) { | ||
| toast.error(errorMessage) |
Contributor
There was a problem hiding this comment.
Should be in app facing code and not core library? Developer might decide to show the error "inline" instead of a toast. The example you show in the PR description is a good example of this, if the dialog button triggers the upload error, it's better to show the error inside the dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue