fix: save() fails with TypeError: dict can not be used as parameter for Single DocTypes

[prateekjoshi44]

Versions

• frappe-ui: 0.1.261
• frappe: 15.110.0
• crm: 1.73.0

Describe the bug
Calling document.save.submit() on a Single DocType (e.g. CRM Twilio Settings)
fails with:

TypeError: dict can not be used as parameter

Root Cause
In documentResource.js, the save resource uses frappe.client.set_value
and passes the entire doc object as fieldname:

return {
  doctype: out.doctype,
  name: out.name,
  fieldname: values, // entire doc object — crashes for Single DocTypes
}

frappe.client.set_value cannot handle a dict as fieldname parameter.

Fix
Use frappe.client.save instead, which accepts the full doc correctly.
PR attached.

[barista-for-frappe]

Confirmed against the code — the analysis is accurate.

• save reuses setValueOptions (frappe.client.set_value) and passes the whole doc dict as fieldname (src/resources/documentResource.js:110-118).
• set_value is built for partial field updates, not full-doc saves; the dict-as-fieldname path breaks for Single DocTypes (name === doctype), hence TypeError: dict can not be used as parameter.
• Switching save to frappe.client.save (full doc) is the right fix, as you propose. Note beforeSubmit/onError read params.fieldname (:48, :117), so the param shape change needs to be threaded through there too.

Will review the attached PR.

_{barista · claude-opus-4-8 · 8.8k in / 3.1k out · 780k cached · 68s · $0.420}

[prateekjoshi44]

PR submitted: #768