Skip to content

fix(Job Card): apply precision to total time in minutes #50757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(Job Card): apply precision to total time in minutes #50757

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46088f
fix(Job Card): apply precision to total time in minutes
barredterra Nov 26, 2025
11e0590
fix(Job Card): ensure completed_time and completed_qty are updated wi…
barredterra Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions erpnext/manufacturing/doctype/job_card/job_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,16 @@ def validate_time_logs(self, save=False):
)

if d.from_time and d.to_time:
d.time_in_mins = time_diff_in_hours(d.to_time, d.from_time) * 60
d.time_in_mins = flt(
time_diff_in_hours(d.to_time, d.from_time) * 60, d.precision("time_in_mins")
)
self.total_time_in_mins += d.time_in_mins

if d.completed_qty and not self.sub_operations:
self.total_completed_qty += d.completed_qty

self.total_completed_qty = flt(self.total_completed_qty, self.precision("total_completed_qty"))
self.total_time_in_mins = flt(self.total_time_in_mins, self.precision("total_time_in_mins"))

if save and self.docstatus == 1:
self.db_set(
Expand Down Expand Up @@ -651,17 +654,27 @@ def update_sub_operation_status(self):
if row.status != "Complete":
row.status = operation_deatils.status

row.completed_time = operation_deatils.completed_time
completed_time = flt(operation_deatils.completed_time, row.precision("completed_time"))
if operation_deatils.employee:
row.completed_time = row.completed_time / len(set(operation_deatils.employee))
completed_time = flt(
operation_deatils.completed_time / len(set(operation_deatils.employee)),
row.precision("completed_time"),
)

if operation_deatils.completed_qty:
row.completed_qty = operation_deatils.completed_qty / len(
set(operation_deatils.employee)
row.completed_qty = flt(
operation_deatils.completed_qty / len(set(operation_deatils.employee)),
row.precision("completed_qty"),
)

# Only update completed_time if value actually changed.
# completed_time is a Data (string) field, so compare as floats
if flt(row.completed_time) != completed_time:
row.completed_time = completed_time
else:
row.status = "Pending"
row.completed_time = 0.0
if flt(row.completed_time) != 0.0:
row.completed_time = 0.0
row.completed_qty = 0.0

def update_time_logs(self, row):
Expand Down