Skip to content

feat(asset): make asset depreciation failure notification role configurable #50746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+12 −2
Open

feat(asset): make asset depreciation failure notification role configurable #50746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e830cca
feat(asset): make asset depreciation failure notification role config…
SowmyaArunachalam Nov 25, 2025
d52d986
chore: update description
SowmyaArunachalam Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion erpnext/accounts/doctype/accounts_settings/accounts_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
"calculate_depr_using_total_days",
"column_break_gjcc",
"book_asset_depreciation_entry_automatically",
"role_used_for_depreciation_failure",
"closing_settings_tab",
"period_closing_settings_section",
"acc_frozen_upto",
Expand Down Expand Up @@ -658,6 +659,13 @@
"fieldname": "use_legacy_controller_for_pcv",
"fieldtype": "Check",
"label": "Use Legacy Controller For Period Closing Voucher"
},
{
"description": "Users with this role will be notified if the asset depreciation gets failed",
"fieldname": "role_used_for_depreciation_failure",
"fieldtype": "Link",
"label": "Role used for Depreciation Failure",
"options": "Role"
}
],
"grid_page_length": 50,
Expand All @@ -666,7 +674,7 @@
"index_web_pages_for_search": 1,
"issingle": 1,
"links": [],
"modified": "2025-10-20 14:06:08.870427",
"modified": "2025-11-24 23:36:21.829372",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Accounts Settings",
Expand Down
1 change: 1 addition & 0 deletions erpnext/accounts/doctype/accounts_settings/accounts_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class AccountsSettings(Document):
reconciliation_queue_size: DF.Int
role_allowed_to_over_bill: DF.Link | None
role_to_override_stop_action: DF.Link | None
role_used_for_depreciation_failure: DF.Link | None
round_row_wise_tax: DF.Check
show_balance_in_coa: DF.Check
show_inclusive_tax_in_print: DF.Check
Expand Down
3 changes: 2 additions & 1 deletion erpnext/assets/doctype/asset/depreciation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ def set_depr_entry_posting_status_for_failed_assets(failed_asset_names):


def notify_depr_entry_posting_error(failed_asset_names, error_log_names):
recipients = get_users_with_role("Accounts Manager")
user_role = frappe.db.get_single_value("Accounts Settings", "role_used_for_depreciation_failure")
recipients = get_users_with_role(user_role or "Accounts Manager")

if not recipients:
recipients = get_users_with_role("System Manager")
Expand Down
Loading