Skip to content

Allow Symfony 5.0#98

Merged
franzliedke merged 1 commit into
franzliedke:masterfrom
emodric:patch-2
Nov 29, 2019
Merged

Allow Symfony 5.0#98
franzliedke merged 1 commit into
franzliedke:masterfrom
emodric:patch-2

Conversation

@emodric

@emodric emodric commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@franzliedke franzliedke merged commit 013cce6 into franzliedke:master Nov 29, 2019
@franzliedke

Copy link
Copy Markdown
Owner

Thanks a lot!

@simonberger

Copy link
Copy Markdown

@emodric @franzliedke It seems not to be compatible to symfony 5 though

PHP Fatal error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given

https://github.com/symfony/symfony/blob/5.0/UPGRADE-5.0.md#process

@emodric

emodric commented Jan 28, 2020

Copy link
Copy Markdown
Contributor Author

Doh! When I tested the package, I somehow didn't notice that I was using Symfony 4.4 instead of 5.0, so there were no issues :/

What would be the best way to fix this? Some form of version detection? The new syntax was introduced in Symfony 3.3 I believe.

franzliedke added a commit that referenced this pull request Dec 18, 2020
@franzliedke

Copy link
Copy Markdown
Owner

@emodric @simonberger That problem only occurred within studio create, right? That now works with Symfony 5 after this commit.

This has been relased in version 0.15.0.

@simonberger

Copy link
Copy Markdown

I absolutely don't remember what I did back then 😎

@emodric

emodric commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

I don't really remember either 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants