-
Notifications
You must be signed in to change notification settings - Fork 7
Replace lz4 and lzo with in-tree Rust #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 87.90% 0.00% -87.91%
==========================================
Files 21 22 +1
Lines 1356 1362 +6
==========================================
- Hits 1192 0 -1192
- Misses 164 1362 +1198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #56 will not alter performanceComparing Summary
|
07e3c6c to
fdef9a8
Compare
Miauwkeru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the workflow gets merged in, LGTM
Co-authored-by: Miauwkeru <[email protected]>
They no longer exist and are no longer necessary since fox-it/dissect.util#56
Experimental branch for playing around with Rust powered modules. With this POC I initially set out to replace the dependencies on the
lz4andpython-lzoPython dependencies, and replacing them with a Rust powered extension.The concept here is that we will use
setuptools-rustto build wheels that contain the Rust compiled extension, but we will not change the build system inpyproject.toml. This is to ensure that we will never compile when installing a "source wheel". Instead, we will continue to usetox -e buildto build Python-only wheels, and in parallel build Rust wheels withsetuptools-rust. The theory here being that on apip install, the following will happen:Play along at home:
Depends on fox-it/dissect-workflow-templates#44